emile icon indicating copy to clipboard operation
emile copied to clipboard

opts.after callback function called twice

Open cmawhorter opened this issue 14 years ago • 3 comments

I'm using FF 3.5.7. I'm not sure if this bug is unique to my browser/setup or not.

To reproduce:
emile( el, 'margin-top:120px;', {duration:150, after:function() { console.log('here'); }} );

"here" is printed twice.

Also, one more unrelated thing: options.after would be significantly more useful if you made one small change to emile.js:

Change line 48 from: if(time>finish) { clearInterval(interval); opts.after && opts.after(); }

To: if(time>finish) { clearInterval(interval); opts.after && opts.after.call(el, opts); }

This will make "this" refer to the element being animated in the callback and also provide the options as an argument.

ex: emile( el, 'margin-top:120px;', {duration:150, after:function() { this.className='justanimated'; }} );

Love emile! Great job!

cmawhorter avatar Feb 18 '10 10:02 cmawhorter

Did you ever figure this out? I'm seeing the same thing.

TimHeckel avatar Apr 16 '11 21:04 TimHeckel

No. I was just evaluating emile for fun and had no need to, sorry =/

cmawhorter avatar Jul 25 '11 03:07 cmawhorter

Just tested in Chrome and FF/5 and I'm no longer seeing this issue.

cmawhorter avatar Jul 25 '11 03:07 cmawhorter