respond icon indicating copy to clipboard operation
respond copied to clipboard

Cannot find 'SitesModule' in 'app/sites/sites.module'

Open hiagodotme opened this issue 5 years ago • 8 comments

When I try to access the "Manage Sites" menu the error below is reported on the console.

main.281198f362daffc2bea8.js:1 ERROR Error: Uncaught (in promise): Error: Cannot find 'SitesModule' in 'app/sites/sites.module'
Error: Cannot find 'SitesModule' in 'app/sites/sites.module'
    at tt (main.281198f362daffc2bea8.js:1)
    at main.281198f362daffc2bea8.js:1
    at t.invoke (polyfills.6fe99e701656a00f4585.js:1)
    at Object.onInvoke (main.281198f362daffc2bea8.js:1)
    at t.invoke (polyfills.6fe99e701656a00f4585.js:1)
    at e.run (polyfills.6fe99e701656a00f4585.js:1)
    at polyfills.6fe99e701656a00f4585.js:1
    at t.invokeTask (polyfills.6fe99e701656a00f4585.js:1)
    at Object.onInvokeTask (main.281198f362daffc2bea8.js:1)
    at t.invokeTask (polyfills.6fe99e701656a00f4585.js:1)
    at O (polyfills.6fe99e701656a00f4585.js:1)
    at O (polyfills.6fe99e701656a00f4585.js:1)
    at polyfills.6fe99e701656a00f4585.js:1
    at t.invokeTask (polyfills.6fe99e701656a00f4585.js:1)
    at Object.onInvokeTask (main.281198f362daffc2bea8.js:1)
    at t.invokeTask (polyfills.6fe99e701656a00f4585.js:1)
    at e.runTask (polyfills.6fe99e701656a00f4585.js:1)
    at v (polyfills.6fe99e701656a00f4585.js:1)
    at e.invokeTask [as invoke] (polyfills.6fe99e701656a00f4585.js:1)
    at y (polyfills.6fe99e701656a00f4585.js:1)

hiagodotme avatar Mar 01 '19 12:03 hiagodotme

Thanks for reporting this.

The front-end UI for Respond is built in Angular, and stored in a different Github repo: https://github.com/madoublet/respond-ui

Whenever changes are made in that repo, the Angular project is rebuilt and the compiled .js files are integrated into this main repo. My initial guess is that not all of the compiled .js files were updated the last time around.

I've done the last few updates and sort of had to muddle my way through the process manually as I wasn't clear on the steps used by the original author, @madoublet . I wonder if it's possible to set up some sort of script that will automate pushing changes from the respond-ui repo into the main respond repo?

Maybe I'm getting ahead of myself. I am not even sure that is the problem here. I will try to look at this soon.

axis80 avatar Mar 05 '19 18:03 axis80

I will pull your changes and do a clean build and see if this goes away. The build process is not great at this point. I will see if I can write some scripts to improve it.

madoublet avatar Mar 05 '19 18:03 madoublet

@madoublet an @axis80 when compiling the angled project and adding manually into the main project the problem was solved for me.

hiagodotme avatar Mar 05 '19 20:03 hiagodotme

Would it make sense to include respond-ui as a dependency in packages.json? Whenever there is a change in the UI, you could update your installation with npm update && gulp . There would be some tweaks needed to the gulpfile (and possibly angular.json as well) but I think it should work?

axis80 avatar Mar 05 '19 20:03 axis80

I think this would make sense. I know I had it this way at one point b/c respond-ui is in NPM. https://www.npmjs.com/package/respond-ui

madoublet avatar Mar 05 '19 21:03 madoublet

I rebuilt respond-ui and updated the zip. This should fix the issue. I am not seeing it in my development build.

madoublet avatar Mar 06 '19 03:03 madoublet

@madoublet thank you! Could you update the available angular application in the public directory? When doing my installation I do not extract the .zip file, as I saw that there was already an application in the public directory. I think the @axis80 proposal is valid, since respond-ui is a separate repository of respond.

hiagodotme avatar Mar 07 '19 14:03 hiagodotme

I just double checked the timestamps and it does look like it is updated. Are you still seeing that error? I will work on the @axis80 proposal.

madoublet avatar Mar 07 '19 14:03 madoublet