respond icon indicating copy to clipboard operation
respond copied to clipboard

#572 Docker best practices *stage 1* proposal

Open mrjoops opened this issue 7 years ago • 1 comments

Reference issue #572:

Hi @madoublet !

I work in docker environment 40 hours a week, and my friend @AKAsebu asked me to take a look at the respond docker setup, so here I am. With your permission, here are some suggestions I'd like to make in order to follow some best practices:

  • I saw you recently separated the docker stuff from the main repository. By doing this, you miss the opportunity to create a docker image linked to a revision or a tag, making it harder for people to test stable version of your software.
  • The first point is somewhat biased since your Dockerfile always download the latest archive from github. You should change that too: the Dockerfile should reference the same revision of the code it lives in.
  • That being said, it is a commonly accepted best practice to not store archive files in the source code (ok this is not docker related ;) )
  • Do you know DockerHub ? It is a great place to discover docker images. I found some respond images there but nothing official I think. You could set up an automatic build, linked to your github repo, so your users won't have to build the docker image anymore.

That's all for the "stage 1" proposal. Here is the PR so we could talk about the details, and if you're still interested then we'll talk about the "stage 2" proposal.

mrjoops avatar Jan 07 '18 23:01 mrjoops

Thank you! I am definitely not a docker expert.

madoublet avatar Jan 07 '18 23:01 madoublet