respond icon indicating copy to clipboard operation
respond copied to clipboard

Add Error catching around Webhooks

Open madoublet opened this issue 7 years ago • 2 comments

Add error handling around webhooks at: App\Respond\Models\Submission.php

madoublet avatar Nov 05 '17 14:11 madoublet

Just curious, what is the scenario that makes this necessary? You want to return an error to the end user if the webhook fails when a form is submitted? That seems like a good idea. Another option would be to hand the webhook request over to Lumen's queuing subsystem upon form submission, but that probably adds more complexity to Respond than is really optimal.

axis80 avatar Nov 05 '17 22:11 axis80

I had an error around that reported again. My guess is that it is related to the PHP version. But, I am not certain. I probably won't add error handling around it. I think I would rather just only execute this code if the the webhooks are enabled in the .env file.

madoublet avatar Nov 09 '17 19:11 madoublet