Madelyn Olson

With Valkey 8.0, we now have the ability for clients to indicate that they support a capability. One capability we discussed in Redis was the ability to shed load by...

We've seen a number of failures related to empty shard migration, https://github.com/valkey-io/valkey/actions/runs/10171585430/job/28132822421. ``` *** [err]: Empty-shard migration target is auto-updated after failover in target shard in tests/unit/cluster/slot-migration.tcl incorrect slot state...

> Yeah, this seems OK to me. I'll still create an issue about execution nesting in blocking but we can resolve that after rc1. _Originally posted by @madolson in https://github.com/valkey-io/valkey/pull/712#discussion_r1685914258_

https://github.com/valkey-io/valkey/actions/runs/10127360669/job/28005047625 We see an IO error in the `test_slave_buffers` test which appears to be a legit error ``` === (external:skip cluster) Starting server 127.0.0.1:26643 ok [exception]: Executing test client: I/O...

[Test issue] The tests don't correctly reflect the number of tests left

5

It repeatedly says we are at 124/124 when running, https://github.com/valkey-io/valkey/actions/runs/10805625870/job/29973022674?pr=1016#step:4:5651. I guess you can replicate this with just `make test`. Not sure what is causing it. ``` [124/124 done]: integration/replication-psync...

Thanks for your patience, @bentotten! I think this change makes sense overall. I think we should also consider updating the extension_capable flag right after completing the handshake as below: https://github.com/valkey-io/valkey/blob/089048d36485bf0d0d202221a7497aec0563bcdd/src/cluster_legacy.c#L3194...

Investigate integrating with fast_float

7

I've seen a couple of posts recently about how both dragonflyDB and Redis integrated with https://github.com/fastfloat/fast_float to improve parsing of doubles. We use strtod (exposed as getDoubleFromObject) in sorted set...

[Test Failure] Sync should continue if not all slaves dropped dual-channel-replication

2

Sync should continue if not all slaves dropped dual-channel-replication no in tests/integration/dual-channel-replication.tcl https://github.com/valkey-io/valkey/actions/runs/11283922852/job/31417235703#step:5:7269 Doesn't specifically look like a dual channel issue, but seems to be a test issue.

https://github.com/valkey-io/valkey/actions/runs/11283922852/job/31417233387#step:6:6008 It seems to occur on the replica side. ``` 43813 valkey-server * /lib/x86_64-linux-gnu/libc.so.6(+0x42520)[0x7fd198042520] /lib/x86_64-linux-gnu/libssl.so.3(+0x32aca)[0x7fd1989dfaca] /lib/x86_64-linux-gnu/libssl.so.3(SSL_read+0x27)[0x7fd1989dfcb7] src/valkey-server 127.0.0.1:23382(+0x1fa987)[0x5566f92b0987] src/valkey-server 127.0.0.1:23382(+0x1705f8)[0x5566f92265f8] src/valkey-server 127.0.0.1:23382(rdbLoadRioWithLoadingCtx+0x2f5)[0x5566f91b54f5] src/valkey-server 127.0.0.1:23382(readSyncBulkPayload+0x315)[0x5566f91a6075] src/valkey-server 127.0.0.1:23382(+0x1f310d)[0x5566f92a910d] src/valkey-server 127.0.0.1:23382(+0x1fb9a3)[0x5566f92b19a3] src/valkey-server 127.0.0.1:23382(+0x1fbc34)[0x5566f92b1c34]...

[Feature] Implement CLUSTER FLUSHSLOT command

5

As part of the per-slot dictionary effort, we implemented all of the needed changes so that we could efficiently unlink and free the data in a single slot with lazyfree....