Madelyn Olson

Results 414 comments of Madelyn Olson

@zuiderkwast There is some value in replicating the import slot synchronously on the target. I think the most interesting example is as follows (Assume 2 primaries and two replicas across...

@zuiderkwast I don't really want to block progress here on a potential future implementation that doesn't fork. There are a lot of other problems that need to be resolved before...

> As a nitpick, I think the using the term 2PC here is a distraction - we don't have a coordinator and there are only two entities which reach agreement....

> I suggest preserving the current behavior of gossiping the intermediate state (marking slot X as being imported/migrated in the relevant shards) as it would make it easier for an...

@ushachar maybe we want a new "admin health command". That gives a simple summary of important parts of the cluster. Adding it to slots or shards seems wrong, as they...

> @madolson This information is already visible in the current SLOTS/SHARDS output, so keeping it there seems like the path of least resistance... but it's not a big issue either...

We probably want to implement https://github.com/redis/redis/issues/11395 as part of this change as well.

There will be new publish commands, per (https://github.com/redis/redis/pull/8621/files). Mentioning this because the logic for pubsub will also be changed a little bit for cluster mode. There is logic that sets...

@Andrew-Chen-Wang I'm not from Redis Ltd, but perhaps it might make sense to merge in the async functionality into the main repo instead of maintaining a fork? Would that be...

@oranagra The checkLinuxMadvFreeForkBug occurs after moduleLoadFromQueue, so it's possible a module might have been opened.