Madelyn Olson

Results 826 comments of Madelyn Olson

This was previously discussed here: https://github.com/valkey-io/valkey/issues/79. The original decision was very mixed which was why I don't think we originally moved forward with it. Reading it through again, I didn't...

> Another approach is to let both build system co-exist, until a point in time where you (and the core team) feels that its matured enough and a switch can...

> I haven't seen a concrete case personally though. This is probably a situation where we will have to just make the change and see what breaks. We didn't know...

> to deal with cross-platform use cases, which is error-prone and hurts readability IMO. The current system does work though, so ultimately it's a style preference, which I don't find...

Decision is that Eran is going to continue finishing the the porting. For some period of time we will maintain both Make and CMake. At some point in the future...

@eifrah-aws Can you create an issue for 8.1 to make a decision if we need to mark CMake support as experimental for 8.1. We will make it experimental if we...

@PingXie Can you take a look first since your more familiar with CMake and might be able to cover stuff more quickly than I can.

No, I wasn't able to originally reproduce it, and since nobody else brought it up I was just waiting around. It seems like someone else saw it, so going to...

Ok, I was testing against OpenSSL 1.1, I'll try a later instance with 3.0.