Madelyn Olson

Results 634 comments of Madelyn Olson

I'm getting segfaults when trying to test the change: ``` redis $./src/redis-benchmark --readonly -p 30001 PING Segmentation fault: 11 redis $./src/redis-benchmark --readonly -p 30001 -t get *2 $3 GET $16...

My initial thoughts: 1. I personally don't think we should add a second scripting language to Redis without a clear motivation, which isn't documented here. It adds more blast radius...

> I think we can support many of the popular java script libraries, anything that's pure JS (people will bring it in on their own from NPM, no need to...

> There are a lot of bundlers that does just that, take a look at [webpack](https://webpack.js.org/guides/getting-started) for example. I will stand corrected and say that being able to easily use...

Based on our discussion we said it's not required for any correctness reasons, but realistically within Redis it is never omitted, it seems weird to put it as optional when...

I'm not the biggest fan of building the callbacks you outlined. I think it's sort trying to optimize just this one use case, instead of building a good set of...

@daniel-house Sorry for ignoring you for so long, this has been rattling in the back of my head and I do think we need to address it. I still want...

Just as a proof of concept, I think interceptors can work. I built a simple POC using this existing module filters, https://github.com/madolson/redis/commit/e3a1bc5d3f41e74a59ab00bdf5f0dcc09aa4ca98, and it seems to cover the AUTH case...

If someone has time, building a reference implementation would be helpful. I think we can investigate adding some hooks that help tactically make the experience more straightforward to implement.

I agree let's close this one. @daniel-house Do you want to check out the new issue and comment if it solves your use case?