Madelyn Olson
Madelyn Olson
@SoulPancake The only one not picked up right now is dict.c.
> At the same time, it looks very close to documentation. Can a proposal like this live as an open PR to the docs repo? The main difference, imo, is...
@hwware I agree with that. Don't start with the VCP, start with the high level proposal first.
Created rfc repo here https://github.com/valkey-io/valkey-rfc
Ran a more complete set of tests here: https://github.com/madolson/valkey/actions/runs/8952734788.
@PingXie https://github.com/valkey-io/valkey/blob/1b3199e0705817e2cdd8bca6ce3ab3b3567b4573/src/unit/test_intset.c#L83 was one such example. It's worth mentioning that this is only happens on the inlined versions, and not the actual usages of it. I'm not entirely clear why...
Looks like a lot of this work got split up and handled in other PRs, so going to close this.
@PingXie Thoughts ^
> The other half of the same struct is related to the cluster bus. Is it worth splitting the struct? The current abstraction is that the clusterbus owns the underlying...
@srgsanky ~~The commit missing the DCO is just the top one. You should just be able to do `git commit -s --amend` with a no-op and force push over what...