Madelyn Olson

Results 445 comments of Madelyn Olson

I can provide a little context about Redis cluster. There are two ports for Redis during cluster mode, the main port for accepting incoming commands and a separate port that...

Redis exporter should be configured to talk to the client configured port, it's just acting like a regular old client to pull data out of Redis.

The only strong opinion I have from the open questions is we should make it a runtime flag. A three year transition sounds good to me.

> I am curious why advertising IP and switching to hostname is bad for a client. For a TLS cluster, will the client fail to establish connection if they see...

@zuiderkwast Will work on refining the PR a little bit, and propose it again before Valkey 8.

> I think it would be fairly easy to introduce a new message in the "legacy" cluster bus to send pubsub messages without the full Ping packet (slot bitmap, etc.)....

> I would lean towards a non breaking change as Pub/Sub mechanism shouldn't be restricted due to cluster coverage issue. The concern I had with this is then we aren't...

> Then we would not break the behavior from user side, maybe a new message type in cluster bus is an internal breaking change, but this is introduced in a...

We're parking this PR for the time being while we evaluate if https://github.com/valkey-io/valkey/issues/557 will solve the scalability issues.

> One thing which I wanted a decision on before closing this PR. For now I think it's an unnecessary breaking change. We can fix it with cluster v2 if...