Madelyn Olson

Results 414 comments of Madelyn Olson

> I see. I agree stage uncommitted operations is another option. It is very easy to implement for hash table. You can perform additional lookup on the staged changes before...

@oranagra You mentioned earlier that you had some thought about how lua rollback can work in the past, would you mind elaborating on that and chiming in what you think...

More or less yeah, we also have more information here: https://github.com/redis/redis/security/policy. Seems like they should be merged a bit since we don't have the GPG key linked from the policy.

Sorry for chiming late. I agree that I don't think we should just "skip" module data. Adding a change where a module can declare if auxiliary data is optional seems...

I broadly agree with this, and had a backlog to post something very similar to this post. I have no real objection to modules being able to add commands to...

Can we not resolve that as long as modules are loaded before ACLs? Since modules will add both new commands as well as categories.

Someone from AWS is going to take a look at some of these improvements.

> @madolson i imagine such a thing is a much bigger task with some chance for issues from race conditions. Yes, I don't think we should address the wider issue...

@weim0000 Cool, change looks gtm. Would you be comfortable adding a test around this case? Want to avoid future regressions here, since we clearly weren't testing for it.

@weim0000 I moved the test to the new framework, so now the tests will run as part of CI. Also kicked off a full test run here: https://github.com/redis/redis/actions/runs/2897153567.