Madelyn Olson
Madelyn Olson
So I suppose the consensus is we will take it and move it under our umbrella. One point I do want to ask about is we would prefer only taking...
Do we still need this change with https://github.com/redis/redis/pull/12159 ? It seems like you should be able to do everything asked for here.
@oranagra Couldn't it allow modules to execute commands in batches, which was one of the alternatives mentioned here?
> simple flush API I think you're abusing the term simple here. Simple doesn't just mean simple to implement, but simple to reason about and understand. We could directly expose...
> that's what we're aiming to achieve here. i thought an explicit API is better than closing and re-opening a context, but i'm also ok with forcing modules who want...
There is another important point here, which is if we moved to cluster V2 we would no longer need to maintain cluster links for pubsub. Some context, this was approved...
> LGTM, btw, why didn’t we choose replication stream for shard pub/sub at the beginning? I think compatibility with the way the cluster worked was the main reasoning. Since you...
> We'd still need to support cluster bus for unsharded pubsub right? For cluster bus, we will probably need to continue supporting it. Cluster v2 will be an opt-in feature,...
> Since it's quite a short list of changes in this changelog, we can expand each item with some more details about compatibility, etc. I added some suggestions. This was...
> the reply-schema ci is failing, look like we need to pick https://github.com/valkey-io/valkey/pull/133 It was already picked at the time, I wasn't sure why this PR wasn't picking up the...