Madelyn Olson
Madelyn Olson
@PingXie I'm fine punting it out of this PR to unblock as you mentioned. let me know if i can help, since I am the major one pushing for the...
Core group approved, but waiting on @yossigo to take a look before merging.
@PingXie Some counter points: 1. I actually think `CLUSTER SHARDS` is a *bad* Admin command. Why? It doesn't expose all of the internal state of cluster nodes. We ideally should...
I guess I missed that this was a breaking change. I was looking at the comment from https://github.com/redis/redis/pull/9504: ``` Command stats now show the stats per subcommand (e.g. instead of...
> what do you mean? We had automation looking for the cluster field field, that info field disappeared. It's possible other folks are looking for that as well. > I...
I'm not convinced people adopted the new functionality all that quickly. I think it's more likely software just silently stopped working. In our case, our code was looking for the...
I think everyone has weighed in, consensus seems to be to accept the change. Will close unless someone else provides more justification.
@oranagra Will you take a look at this? This is related to AWS and related to module configs. We want to replicate a change after a module config is applied,...
> module commands are propagated very differently from redis commands (based on explicit propagation rather than the dirty counter), even if we're not happy with it, i don't think we...
@yyyhe You mentioned there was some issue when we discussed removing dirty++ internally, something about running module APIs from lua scripts. I made the suggestion locally and ran the tests...