Mathieu Brunot
Mathieu Brunot
It would be nice to have automated tests of PowerDNS, ideally using docker-compose to provide external database. Might send a PR for this as well.
Use COPY instead of ADD for files and folders: https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#add-or-copy
`MAINTAINER` has been deprecated in favor of `LABEL maintainer`: https://docs.docker.com/engine/reference/builder/#maintainer-deprecated Also, might be a good idea to add some "_standard_" labels to the image: * OpenContainer annotations: https://github.com/opencontainers/image-spec * Label...
Add GitHub templates for better contribution: https://help.github.com/en/github/building-a-strong-community/configuring-issue-templates-for-your-repository PR incoming.
CODE provides a welcome page at `/dist/welcome/welcome.html` which is designed to be displayed **inside the editor**, but there is no standalone welcome / status page to see if the server...
Shall fix #2
`RUN` commands could be stacked into one to reduce the number of layers and thus decrease the size of the image.
Great work there :+1: It might be nice to also have the FPM Alpine distributions available, maybe even switched current FPM to alpine.
Why is there a hook to zapier ? https://github.com/jvfiel/ERPNext-OCR/blob/621dc8d7212098eed7918985dc3d3a8c394823ae/erpnext_ocr/zap_hooks/SI.py#L18
The OCR Receipt code does not work because there is no `process_xml`: ``` Traceback (most recent call last): File "/home/monogramm/dev/frappe/bench/env/lib/python3.5/site-packages/rq/worker.py", line 793, in perform_job rv = job.perform() File "/home/monogramm/dev/frappe/bench/env/lib/python3.5/site-packages/rq/job.py", line...