Jarolift_MQTT icon indicating copy to clipboard operation
Jarolift_MQTT copied to clipboard

added individual positions based on time

Open krisha opened this issue 5 years ago • 2 comments

krisha avatar Jan 22 '20 23:01 krisha

Hello @krisha,

good idea, I assume a lot of work, but one commit for such a huge change is way to little to merge.

Can you split it into "one commit per logical change" please?

madmartin avatar Apr 05 '20 09:04 madmartin

Thank you for your reply.

Actually I think it is just one logical change. The only thing I can imagine is splitting it to 'logic', 'webserver' and 'webserver help' commits, but not sure if that makes sense.

If I split it further it will not build and/or might not work as expected on the single commits.

If I misunderstood, let me know and if possible please also attach an example.

krisha avatar Apr 05 '20 10:04 krisha