zlib icon indicating copy to clipboard operation
zlib copied to clipboard

Add optimized crc32 for Power 8+ processors

Open mmatti-sw opened this issue 2 years ago • 10 comments

This is a pull request to include all Power8 optimisations rebased to v1.2.13. The reference PR is https://github.com/madler/zlib/pull/478

mmatti-sw avatar Nov 21 '22 15:11 mmatti-sw

@madler: Can you look?

Neustradamus avatar Nov 21 '22 21:11 Neustradamus

I've tried to apply your patch on top of the patch from https://github.com/madler/zlib/pull/410 and it has some rejected hunks (configure.rej Makefile.in.rej ; I can sent you the output if you want).

The previous patch (https://github.com/madler/zlib/pull/478) was rebased on top of that patch, could you please preserve this order?

ljavorsk avatar Nov 22 '22 19:11 ljavorsk

The patches for Power are also maintained and incorporated in zlib-ng if anybody is interested.

nmoinvaz avatar Nov 22 '22 20:11 nmoinvaz

Okay, @iii-i has rebased his patch on top of yours and provided it to me.

I would like to agree on the order in which you'll have them applied, so I don't need to change it too often. Is that okay with you?

ljavorsk avatar Nov 25 '22 14:11 ljavorsk

I am ok with any order you or @iii-i would like to follow.

mmatti-sw avatar Nov 29 '22 07:11 mmatti-sw

I'd prefer POWER patches to go first, since they provide a foundation for adding optimized CRC32 implementations.

iii-i avatar Nov 29 '22 13:11 iii-i

Okay, I agree with that. Thank you

ljavorsk avatar Nov 29 '22 13:11 ljavorsk

Hi, could you please rebase your patches on top of zlib-1.3 version?

ljavorsk avatar Aug 22 '23 10:08 ljavorsk

@ljavorsk: Have you seen the @mmatti-sw PR?

  • https://github.com/madler/zlib/pull/857

Neustradamus avatar Jan 21 '24 11:01 Neustradamus

Hi, sorry @mmatti-sw for the inconvenience. We've transitioned to zlib-ng from Fedora 40, and thus we don't plan to rebase the zlib anymore.

This means, that you can fully focus on the zlib-ng PRs from now on.

ljavorsk avatar Jan 22 '24 09:01 ljavorsk