zlib
zlib copied to clipboard
Never ever edit files in source directory
Why you are renaming file zconf.h to zconf.h.included in source files? (CMakeLists.txt:77)
It is making the git revision as dirty and force users to fetch your code to build directory instead to use it as a git submodule.
I see that you already have file zconf.h.in, so why you are not using configre_file
function to generate zconf.h in build directory. Then only you need to do is to add target_include_directories(${PROJECT_NAME} PUBLIC ${CMAKE_CURRENT_BINARY_DIR})
. zconf.h shall then be also be removed from source code.
Please consider it ASAP
I also ran into this issue, which makes my top level git repository state untracked changes and such.
This .included
nonsense can't be disabled by revoking permission either because then the entire build fails!
I've just submitted a pull request to resolve this as part of #162. It already uses configure_file
but with zconf.h.cmakein
instead of zconf.h.in
.
This is a duplicate of #162.