zlib icon indicating copy to clipboard operation
zlib copied to clipboard

Additional 64 bit support request for openJDK

Open LanceAndersen opened this issue 5 years ago • 5 comments

If possible, could you please consider adapting the changes below into the next release of zlib as we need to make these changes when we take the latest zlib release. Once these changes are incorporated, we should be able to take releases un-modified.

Thank you for your consideration.

Zlib-OpenJDK-Changes.txt

LanceAndersen avatar Jun 27 '19 21:06 LanceAndersen

Why do you need to make these changes?

madler avatar Jun 27 '19 21:06 madler

I was not involved in the original build changes to OpenJDK/Java SE, but this was needed to support some of the platforms openJDK runs on as described in http://gcc.gnu.org/onlinedocs/cpp/Common-Predefined-Macros.html#Common-Predefined-Macros:

_LP64

These macros are defined, with value 1, if (and only if) the compilation is for a target where long int and pointer both use 64-bits and int uses 32-bit.

LanceAndersen avatar Jun 28 '19 17:06 LanceAndersen

We've recently had many users report issues that might be connected to this. While many linux distro just backported the latest security fix to 1.2.11, it looks like arch linux (and others?) just updated to 1.2.12 and now java fails when using CRC32 or opening jar files,see bbs.archlinux.org/viewtopic.php?id=275421 stackoverflow.com/questions/71757009/strange-java-behaviour-with-zip-files-including-jars As openjdk builds rely on system installed zlib, I think this is fairly important change to fix and release as breaks java usage on those systems

jiaz83 avatar Apr 11 '22 15:04 jiaz83

I've just got feedback from arch linux user that downgrading back to 1.2.11 fixes the issue with java

jiaz83 avatar Apr 11 '22 15:04 jiaz83

Thomas Backlund from mageia fix this issue backporting https://github.com/madler/zlib/commit/ec3df00224d4b396e2ac6586ab5d25f673caa4c2 to 1.2.12

katnatek avatar Apr 16 '22 22:04 katnatek