Feature/improve cmake

[ClausKlein]

add option to build either shared or static lib

fix build problems on msys2 and conan

see https://github.com/bincrafters/community/issues/205 and https://github.com/conan-community/conan-zlib/issues/32

[mattparks]

I had to make this minor change to build on Android: https://github.com/albrematt/zlib/commit/130e7b08ea3f108909b0b688cd4befec29e1dbbe

Before this change I would get the following compiler error: error: unknown type name 'z_size_t'

[puneetmatharu]

Are there any plans to merge this PR? I would certainly find it helpful so that I can fetch zlib via FetchContent.

[Neustradamus]

There are a lot of:

CMake PRs:

• https://github.com/madler/zlib/pulls?q=is%3Apr+is%3Aopen+cmake

CMake Issues:

• https://github.com/madler/zlib/issues?q=is%3Aissue+is%3Aopen+cmake

[puneetmatharu]

True. I thought I'd prod just in case it might lead to these changes pushed through.

It's not a problem anymore though, I've made my own fork with the changes I require. Thanks!

[madler]

These commits are out of date.

[Neustradamus]

@madler: @ClausKlein has done an update since 2018:

• https://github.com/madler/zlib/pull/347/commits

[madler]

@Neustradamus This is #347.

[Neustradamus]

@madler: Yes it has been recently updated

[madler]

@Neustradamus My comment was hours ago, and so was referring to the most recent updates.

[Neustradamus]

@madler: Sorry!

@ClausKlein: Can you look?

[ClausKlein]

These commits are out of date.

Sorry, I have rebased with current develop now.

[Neustradamus]

@ClausKlein: Thanks :)

@madler: It is good?

[Neustradamus]

@madler: Can you look this updated PR?

[tritao]

Can this be merged?