zlib icon indicating copy to clipboard operation
zlib copied to clipboard

Add vc15 build files to contrib/vstudio.

Open Sav0966 opened this issue 8 years ago • 11 comments

I've added vc15 build fileles and tested the result with Visual Studio 2017 professional (Windows 10 and SDK 10.0.15063.0). Also I've added brebuild steps to zlibstat project (Release x64/Win32 configurations) to compile assembler files there.

Sav0966 avatar Jul 02 '17 14:07 Sav0966

See also #243.

tbeu avatar Aug 15 '17 07:08 tbeu

Thanks

From: tbeu [mailto:[email protected]] Sent: Tuesday, August 15, 2017 12:27 PM To: madler/zlib [email protected] Cc: Dmitry Savelev [email protected]; Author [email protected] Subject: Re: [madler/zlib] Add vc15 build files to contrib/vstudio. (#270)

See also #243https://github.com/madler/zlib/pull/243.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/madler/zlib/pull/270#issuecomment-322396032, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AOTWUdrZ6sDMLr5-i_ER9CTjwzxAlSkvks5sYUhBgaJpZM4OLmWl.

Sav0966 avatar Aug 15 '17 08:08 Sav0966

The project already has cmake support. Why would one check in static MSVC project files when you can have cmake generate them for you, for whichever version of Visual Studio that you have?

jeking3 avatar Nov 20 '17 13:11 jeking3

Why would one check in static MSVC project files when you can have cmake generate them for you, for whichever version of Visual Studio that you have?

To have all the nice features of static VS project files, e.g., multi-configuration, search, manual adaption of settings etc.

tbeu avatar Nov 20 '17 13:11 tbeu

You can keep your search files around and regenerate project files from cmake. CMake creates multi-configuration projects.

jeking3 avatar Nov 20 '17 15:11 jeking3

It's good that you can also build configurations with CMake. But a VC project file can be built directly with MSBuild without even opening VS, no need to manually create configurations first, it can be opened in VS with all files nicely organized, it can be debugged more easily.

So why can't we just merge this? It won't prevent anyone from using CMake.

lukasf avatar Jan 17 '19 20:01 lukasf

Author of this repo has been /afk for 2 years, so not sure anything's going to happen.

jeking3 avatar Jan 17 '19 22:01 jeking3

Oh I see, that's too bad...

lukasf avatar Jan 18 '19 08:01 lukasf

It's not correct, see the development in devel branch. But AFAIK contrib/ directory is not supported, see the README.

praiskup avatar Jan 18 '19 11:01 praiskup

Well then @madler has the GitHub site configured incorrectly, as all the pull requests are targeting master and not develop.

jeking3 avatar Jan 18 '19 20:01 jeking3

@praiskup We don't want support, the files there work correctly. We'd just like to add one more build file for latest VS version...

lukasf avatar Jan 18 '19 21:01 lukasf