zlib icon indicating copy to clipboard operation
zlib copied to clipboard

fixed compilation in MSVC 2013 and enable IOWIN32_USING_WINRT_API only on non-desktop Windows platforms

Open kolomenkin opened this issue 9 years ago • 9 comments

On my computer I have WINAPI_FAMILY_ONE_PARTITION undefined and WINAPI_FAMILY_PARTITION defined. This generates compilation error with current development sources.

I have MSVC 2013 update 5, windows 8.1, SDK 8.1

I modified the code to have few changes:

  • check for WINAPI_FAMILY defined to decide current SDK knows about different Microsoft platforms.
  • include <winapifamily.h> when it is available. It guarantees WINAPI_PARTITION_DESKTOP is really defined here.
  • define IOWIN32_USING_WINRT_API only on non-desktop platforms. So we support very old API on desktop and support as much Windows version as possible. In other case we would support Windows 8 only.

kolomenkin avatar Feb 02 '16 14:02 kolomenkin

pull requests was updated

kolomenkin avatar Mar 01 '16 10:03 kolomenkin

The zlib 1.2.11 still don't have this commit . Is it going to be in next releases.

asfaque-alam avatar Aug 02 '17 13:08 asfaque-alam

unfortunately I can't check this in nearest future

kolomenkin avatar Sep 07 '17 07:09 kolomenkin

@timofonic, I found some time.

I can't build latest develop branch of https://github.com/Dead2/zlib-ng/ because of

  1. missing zconf-ng.h
  2. missing minizip contrib subdir

Maybe you are generating zconf-ng.h by some configure script, but original zlib did not need configure step. And it could be built in Windows by just adding existing sources to another project.

kolomenkin avatar May 14 '18 22:05 kolomenkin

Please note that there is https://github.com/nmoinvaz/minizip.

Neustradamus avatar Jan 21 '19 14:01 Neustradamus

I do not get the status of this PR. Do you need any actions from me?

kolomenkin avatar Apr 15 '21 10:04 kolomenkin

Already fixed in https://github.com/madler/zlib/commit/ce12773790517034317274f5c65ba70cfeea29f7 ?

philippeVerney avatar Jul 29 '23 10:07 philippeVerney

Already fixed in ce12773 ?

Yes, finally. Duplicate of #233.

tbeu avatar Aug 06 '23 15:08 tbeu

Linked to:

  • https://github.com/madler/zlib/pull/610

Neustradamus avatar Aug 06 '23 15:08 Neustradamus