zlib icon indicating copy to clipboard operation
zlib copied to clipboard

[OS400] Fixed service program path, specified library instead of *LIBL

Open Chi-Iroh opened this issue 2 months ago • 1 comments

Hi !

https://github.com/madler/zlib/blob/5a82f71ed1dfc0bec044d9702463dbdf84ea3b71/os400/make.sh#L15 In os400/make.sh, we can choose in which library the final service program is outputted, and the library is even created if it doesn't exist : https://github.com/madler/zlib/blob/5a82f71ed1dfc0bec044d9702463dbdf84ea3b71/os400/make.sh#L164-L169 We can see the service program being created there in ${TARGETLIB} : https://github.com/madler/zlib/blob/5a82f71ed1dfc0bec044d9702463dbdf84ea3b71/os400/make.sh#L329-L337

But at the end, when adding the service program to the BNDDIR, it's passed as *LIBL/${SRVPGM} and not as ${TARGETLIB}/${SRVPGM}. https://github.com/madler/zlib/blob/5a82f71ed1dfc0bec044d9702463dbdf84ea3b71/os400/make.sh#L363-L365

Seems like an issue to me, as the newly created library isn't added to *LIBL, so it seems wrong to search the service program in *LIBL.

Chi-Iroh avatar Oct 20 '25 14:10 Chi-Iroh

@madler: Have you seen OS/400 PRs done by @Chi-Iroh?

  • https://github.com/madler/zlib/pull/1092
  • https://github.com/madler/zlib/pull/1093
  • https://github.com/madler/zlib/pull/1094
  • https://github.com/madler/zlib/pull/1095
  • https://github.com/madler/zlib/pull/1096

Linked to:

  • https://github.com/madler/zlib/issues/1110

Neustradamus avatar Nov 17 '25 22:11 Neustradamus