nash icon indicating copy to clipboard operation
nash copied to clipboard

Improve logging on Completer

Open katcipis opened this issue 3 years ago • 1 comments

Not sure if exposing a Log method is the best way to go, but wanted to respect the debug configuration.

katcipis avatar Nov 10 '20 15:11 katcipis

Codecov Report

Merging #285 (4160571) into master (9ce2534) will decrease coverage by 0.56%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #285      +/-   ##
==========================================
- Coverage   42.32%   41.75%   -0.57%     
==========================================
  Files          52       52              
  Lines        7318     6378     -940     
==========================================
- Hits         3097     2663     -434     
+ Misses       3931     3429     -502     
+ Partials      290      286       -4     
Impacted Files Coverage Δ
cmd/nash/completer.go 0.00% <0.00%> (ø)
internal/sh/shell.go 62.80% <0.00%> (-2.52%) :arrow_down:
nash.go 40.35% <0.00%> (-4.10%) :arrow_down:
stdbin/mkdir/main.go 10.00% <0.00%> (-13.08%) :arrow_down:
internal/sh/log.go 50.00% <0.00%> (-10.00%) :arrow_down:
ast/tree.go 30.00% <0.00%> (-8.47%) :arrow_down:
internal/sh/builtin/len.go 53.84% <0.00%> (-7.27%) :arrow_down:
tests/cfg.go 46.66% <0.00%> (-6.28%) :arrow_down:
internal/sh/cmd.go 74.00% <0.00%> (-4.34%) :arrow_down:
readline/password.go 8.33% <0.00%> (-4.17%) :arrow_down:
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9ce2534...4160571. Read the comment docs.

codecov-io avatar Nov 10 '20 20:11 codecov-io

wow this is old, sorry =(

i4ki avatar Jan 12 '23 15:01 i4ki

fala xiru véio!

Best Regards,

Alfredo Tomio Junior +31 684431787

On Fri, Jan 13, 2023 at 1:30 AM Tiago Cesar Katcipis < @.***> wrote:

Merged #285 https://github.com/madlambda/nash/pull/285 into master.

— Reply to this email directly, view it on GitHub https://github.com/madlambda/nash/pull/285#event-8216340498, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGWUICAORDDFAUOBE7FVHLWSCO37ANCNFSM4TQ2V3MA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

rootshell2 avatar Jan 13 '23 12:01 rootshell2