nash
nash copied to clipboard
Added 'rglob' function to stdlib.
Codecov Report
Merging #242 into master will decrease coverage by
0.01%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #242 +/- ##
==========================================
- Coverage 56.96% 56.94% -0.02%
==========================================
Files 26 25 -1
Lines 4403 4401 -2
==========================================
- Hits 2508 2506 -2
Misses 1653 1653
Partials 242 242
Impacted Files | Coverage Δ | |
---|---|---|
internal/sh/util.go | 75% <0%> (-4.55%) |
:arrow_down: |
internal/sh/rfork.go |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 556fbc5...78de908. Read the comment docs.
@vitorarins https://github.com/DoctorWkt/unix-jun72/blob/master/src/cmd/glob.c
Version 1 of unix had a program called glob
, very useful =) Maybe we create a tool like that in stdbin to be used in conjunction with our rglob
function.
@tiago4orion the idea is to remove the builtin glob function then ?
Maybe we create a tool like that in stdbin...
Awesome!
@katcipis @tiago4orion What do you think about creating a new glob that is capable of accepting the two asterisks (**
) syntax?
@katcipis I don't think so. I prefer a builtin function that handles ** also, or a function in stdlib.. I sent the link to the unix glob because maybe we can create a helper binary to help the rglob nash function. But maybe this doesn't make sense.
@tiago4orion If the builtin function will continue to exist I see very little incentive to have a helper binary...not sure in what will exactly it help if we give support on the glob function.