nash
nash copied to clipboard
Enables | close to variable token
Closes #188
Codecov Report
Merging #195 into master will increase coverage by
0.01%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #195 +/- ##
==========================================
+ Coverage 55.9% 55.91% +0.01%
==========================================
Files 22 22
Lines 3998 3999 +1
==========================================
+ Hits 2235 2236 +1
Misses 1519 1519
Partials 244 244
Impacted Files | Coverage Δ | |
---|---|---|
scanner/lex.go | 85.89% <100%> (+0.13%) |
:arrow_up: |
internal/sh/rfork_linux.go | 76.19% <0%> (-0.32%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3776d9c...aab08e2. Read the comment docs.
@katcipis by full integrated test you mean adding tests in the interpreter (internal/sh) also?
@tiago4orion actually I was even thinking on testing through the public sh API (the same one we used on klb tests). Less likely to break and gives a code example of what is being done/fixed :-)
@tiago4orion is this PR still relevant? Can we merge?
missing some tests...
tests are too cryptic.. I'll improve that soon
@tiago4orion this will sound a little repetitive with what @vitorarins said, but can we merge this ? =P If it is important we can add better tests later =) (at least it does not break anything and the problem seems serious)