nash icon indicating copy to clipboard operation
nash copied to clipboard

Enables | close to variable token

Open i4ki opened this issue 7 years ago • 7 comments

Closes #188

i4ki avatar Mar 29 '17 04:03 i4ki

Codecov Report

Merging #195 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #195      +/-   ##
==========================================
+ Coverage    55.9%   55.91%   +0.01%     
==========================================
  Files          22       22              
  Lines        3998     3999       +1     
==========================================
+ Hits         2235     2236       +1     
  Misses       1519     1519              
  Partials      244      244
Impacted Files Coverage Δ
scanner/lex.go 85.89% <100%> (+0.13%) :arrow_up:
internal/sh/rfork_linux.go 76.19% <0%> (-0.32%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3776d9c...aab08e2. Read the comment docs.

codecov-io avatar Mar 29 '17 05:03 codecov-io

@katcipis by full integrated test you mean adding tests in the interpreter (internal/sh) also?

i4ki avatar Apr 03 '17 18:04 i4ki

@tiago4orion actually I was even thinking on testing through the public sh API (the same one we used on klb tests). Less likely to break and gives a code example of what is being done/fixed :-)

katcipis avatar Apr 03 '17 20:04 katcipis

@tiago4orion is this PR still relevant? Can we merge?

vitorarins avatar Jun 06 '17 02:06 vitorarins

missing some tests...

i4ki avatar Jun 06 '17 02:06 i4ki

tests are too cryptic.. I'll improve that soon

i4ki avatar Jun 06 '17 03:06 i4ki

@tiago4orion this will sound a little repetitive with what @vitorarins said, but can we merge this ? =P If it is important we can add better tests later =) (at least it does not break anything and the problem seems serious)

katcipis avatar Mar 27 '19 22:03 katcipis