django-google-maps icon indicating copy to clipboard operation
django-google-maps copied to clipboard

Incompatibility with `django-storages` using s3

Open blackwood opened this issue 5 years ago • 1 comments

The extension is incredibly useful. One note: I had to extend the GoogleMapsAddressWidget class so that I could get the file paths correct for my setup using s3 for static assets. I essentially added the django-storages setting into the path.

settings.AWS_S3_CUSTOM_DOMAIN + settings.STATIC_URL + 'django_google_maps/js/google-maps-admin.js',

But I wonder if there's not a way that would handle this automatically, since the other static admin files (for example the ones included with Django) seem to write the path properly.

blackwood avatar Jun 17 '19 23:06 blackwood

I'd be happy to review a pull request if there is a more generic way to accomplish what you are trying to do. I don't know enough about your situation, but is there a reason your settings.STATIC_URL doesn't or couldn't include the AWS_S3_CUSTOM_DOMAIN already?

madisona avatar Jul 17 '19 02:07 madisona