plaid2text
plaid2text copied to clipboard
Option to use other database backend (i.e. SQLite)
I am interested in having a config option to use a different database. SQLite in particular, so that I can store the .db file in Dropbox and access it from different machines. I am thinking of abstracting the StorageManager class into a base class with MongoStorageManager and SQLiteStorageManager derived classes which implement the same functionality. This would also add an option to the initial config setup prompts when no config file is present. If this sounds OK I will plan to open a PR with these changes.
Sounds good Stephen.
On May 10 at 07:23 AM, Stephen Parsons said thus:
I am interested in having a config option to use a different database. SQLite in particular, so that I can store the .db file in Dropbox and access it from different machines. I am thinking of abstracting the StorageManager class into a base class with MongoStorageManager and SQLiteStorageManager derived classes which implement the same functionality. This would also add an option to the initial config setup prompts when no config file is present. If this sounds OK I will plan to open a PR with these changes.
-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/madhat2r/plaid2text/issues/17
Thanks! I've also been making a fair number of minor formatting changes in my fork (e.g. adding spaces between arguments in function calls, some whitespace cleanup, etc) - are you OK with me including all of that or would you rather isolate those changes/keep the current formatting everywhere?
Keep it all :)
On May 10 at 09:30 AM, Stephen Parsons said thus:
Thanks! I've also been making a fair number of minor formatting changes in my fork (e.g. adding spaces between arguments in function calls, some whitespace cleanup, etc) - are you OK with me including all of that or would you rather isolate those changes/keep the current formatting everywhere?
-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/madhat2r/plaid2text/issues/17#issuecomment-388107754
Sorry for the churn - do you mean to keep yours or mine? ;)
If you have improved formatting, then keep yours.
On May 10 at 11:59 AM, Stephen Parsons said thus:
Sorry for the churn - do you mean to keep yours or mine? ;)
-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/madhat2r/plaid2text/issues/17#issuecomment-388151881
This PR adds SQLite backend support, but may break some of the account classification flow. https://github.com/madhat2r/plaid2text/pull/22