music-fns
music-fns copied to clipboard
madewithlove
Translate library to TypeScript
@duivvv Thanks for your note about collaborating. I'm opening this issue to track the work.
I have done some work on my fork. With your permission, I'll merge these changes to a branch on this repository for testing and review.
Hey @spencerudnick, yeah please feel free to do so.
Also: can we make the types available somehow for consumers of the lib, do you have any idea on how that could work?
Can you sync it to the next-release one? (open a PR to merge into it) I would love to look into a babel/TypeScript setup as described here https://iamturns.com/typescript-babel/
Only use TypeScript for the actual typing.
I have a tsconfig setup in another library, which builds to ES5 and includes type definitions along with each module.
I will include that in the PR tonight 😊
On Tue, Jan 22, 2019, 8:18 AM Geoffrey Dhuyvetters <[email protected] wrote:
Hey @spencerudnick https://github.com/spencerudnick, yeah please feel free to do so.
Also: can we make the types available somehow for consumers of the lib, do you have any idea on how that could work?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/madewithlove/music-fns/issues/51#issuecomment-456415020, or mute the thread https://github.com/notifications/unsubscribe-auth/AC7if_LgukONwEbFCdyY47TOh0rQLXigks5vFx2vgaJpZM4aMwng .
If you prefer to use Babel with Typescript, I think all that needs to be
done is to target esnext during TS transpilation.
On Tue, Jan 22, 2019, 12:10 PM Spencer Rudnick <[email protected] wrote:
I have a tsconfig setup in another library, which builds to ES5 and includes type definitions along with each module.
I will include that in the PR tonight 😊
On Tue, Jan 22, 2019, 8:18 AM Geoffrey Dhuyvetters < [email protected] wrote:
Hey @spencerudnick https://github.com/spencerudnick, yeah please feel free to do so.
Also: can we make the types available somehow for consumers of the lib, do you have any idea on how that could work?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/madewithlove/music-fns/issues/51#issuecomment-456415020, or mute the thread https://github.com/notifications/unsubscribe-auth/AC7if_LgukONwEbFCdyY47TOh0rQLXigks5vFx2vgaJpZM4aMwng .
I've started with the conversion based on the link you provided, nice way to develop with TypeScript without using it to compile.
I'm noticing some redundancies after the conversion, so I'll fix those up first.
Hey guys, I'm interested in a conversion happening. I've used TSDX in a bunch of projects, might be a good fit here. https://github.com/formium/tsdx
I might do a big refactor in the future. I always had the idea of creating an internal circle of fifths and take everything from there. Interested in joining?