music-fns icon indicating copy to clipboard operation
music-fns copied to clipboard

Published 20 hours ago • verified publisher icon madewithlove

Chord progressions

Open geoffreydhuyvetters opened this issue 6 years ago • 7 comments

any idea on how we could handle chord progressions?

https://en.wikipedia.org/wiki/Chord_progression

geoffreydhuyvetters avatar Mar 16 '18 15:03 geoffreydhuyvetters

I've done the basics of this on https://plypp.net. There it's basically just a switch case returning the intervals (as midi number) between the root and the rest of the keys in the chord.

enjikaka avatar Jan 14 '19 08:01 enjikaka

Need to re-write the intervals a bit first, thank for the help :)

geoffreydhuyvetters avatar Jan 14 '19 08:01 geoffreydhuyvetters

Oh, read a bit closer now. This was about progression 🙈 I see music-fns already has some chords; done very similar to how I did it on Plypp! I do have some more chords though. Can make a PR for that if we want that in here? (And I can refactor my code out and use music-fns instead! )

enjikaka avatar Jan 14 '19 09:01 enjikaka

That would be awesome :) Feel free to do so.

geoffreydhuyvetters avatar Jan 14 '19 09:01 geoffreydhuyvetters

I don't quite get the naming in this repo though. Using the naming convention of MINOR_MAJOR_SEVENTH and MAJOR_SEVENTH etc will become very cumbersome when we do sus2, sus7, add11 etc. Can we just name them like they are in regular notation? Chord['sus2'] instead of Chord.SUSPENDED_SECOND?

enjikaka avatar Jan 14 '19 09:01 enjikaka

Hmm, not sure. In the case of suspended, I get it.

But I think MAJOR / MINOR etc should be possible, no? We could create aliases Like I did for the intervals?

geoffreydhuyvetters avatar Jan 14 '19 09:01 geoffreydhuyvetters

@duivvv Made a proposal here: https://github.com/madewithlove/music-fns/pull/50 :)

enjikaka avatar Jan 14 '19 09:01 enjikaka