kart
kart copied to clipboard
maddox
Art Editor
:construction: :construction: :construction: :construction: :construction: :construction: :construction: WIP :construction: :construction: :construction: :construction: :construction: :construction: :construction:
This is early, but I'm gonna push it up while I work on it.
This lets you edit the art for a rom right from inside Kart. It adds a new button to the game card that prompts a modal giving choices of art. I wrote a quick consolegrid.com scraper in Ruby and threw it up on Heroku so it had something simple to call out to as an API. It works pretty well.
To Do
- [x] Add loading UI while the api request is still processing.
- [x] Add credit to consolegrid.com in the modal, linking to them.
- [x] Add form for adding art via a URL
- [x] Clean up the modal to just look a little better
- [x] Some error handling
- [ ] Fix loader to be adjusted to where the art will appear
- [ ] Make sure the art results content can scroll with an overflow
- [ ] Add loader when updating art via url
- [ ] Figure out why events stop working after the first time the modal is shown
Added some attribution. The problem is, the links don't open an external browser. I had thought that _blank made it work in the past, but maybe updating atom-shell broke it.
I'd hate to think we have to listen for the click and use shell.openExternal()
i like how this works. WAY easier than downloading files and making sure they get named right and put in the right folder. :metal:
Niceee. Let's get #21 working and landed first, then we'll get #20 landed after that.
Got this close tonight, but ran into some more issues. I added them to the task list.
There's also a problem where the hooked events don't work anymore after the first time the modal is showed. They work the first time, but after that they don't.
This includes clicks on links to art providers in the footer of the modal and the form submission events.