dasher icon indicating copy to clipboard operation
dasher copied to clipboard

Add docker support

Open tekkub opened this issue 9 years ago • 4 comments

👋 @maddox

So I added docker support for you. I included an example docker-compose.yml file too. If you end up pushing an image up to docker hub, you'll want to change the build: . line to image: maddox/dasher.

One caveat: since the docker image runs as root, I skipped your setup script and instead ran the button finder directly:

docker run -it --rm --privileged --net=host tekkub/dasher \
  node node_modules/node-dash-button/bin/findbutton

tekkub avatar Jul 11 '16 09:07 tekkub

I know literally nothing about Docker, lol. So I guess this is all good? @jnewland?

Also, I just created a docker repo here: https://hub.docker.com/r/jonmaddox/dasher/

Could we point it at this? This pull on another of my repos has something regarding this.

maddox avatar Aug 18 '16 05:08 maddox

I was thinking about dockerizing this, and was excited to see this PR. Is there anything that can be done to help get it into dockerhub?

americanwookie avatar Oct 16 '16 23:10 americanwookie

@maddox I have no experience with docker hub myself, I've only really been using docker for my own private things. ¯\_(ツ)_/¯

tekkub avatar Dec 07 '16 11:12 tekkub

I have dockerhub experience! :) It's really easy to link a dockerhub repo with a github repo. I did it myself as a proof of concept with this github repo: https://hub.docker.com/r/americanwookie/rpi3-distribution/. Docker makes it really easy if your comfortable with linking your dockerhub account to your github account and giving docker several permissions.

americanwookie avatar Dec 12 '16 01:12 americanwookie