Daniel Oberhoff

Results 121 comments of Daniel Oberhoff

can someone merge this? :)

ah, linux and windows builds fail, will look into it

> Thanks to @feature-engineer I decided to play with exclamation marks and question marks. I don't like `as!` or `as?` - what I like with the pure `as` is that...

@andersc can you outline the neccessary fixes? we also used a fork and are restrcutruring a bit. also your code seems to have moved into a repo which has no...

I just checked, the only use of string is in PMTElementInfo, should that be replaces by vector or such?

Ok, i tried porting your unit tests, but I think its too hard, so i switched to your fork. One thing: in both versions the demuxer is sensitive to the...

Hmm, thats tricky, I think you kinda assert that packet size is divisible by 188 in your tests, which seems to be a magic number. its kinda obvious though that...

https://github.com/Unit-X/mpegts/issues/1