macvim icon indicating copy to clipboard operation
macvim copied to clipboard

Latest update not respecting background=light

Open kieve opened this issue 6 years ago • 10 comments

I'm using the Dark theme in MacOS Mojave But, I prefer my editors to be light themed.

As of the latest update, MacVIM looks very bad when you define "set background=light"

See: screen shot 2019-02-19 at 10 08 00 am

kieve avatar Feb 19 '19 15:02 kieve

Hi, just to make sure you are using the default macvim colorscheme right?

The latest release switched to fully built in Mojave so the dark mode detection automatically kicks in (which sets a different set of MacTextColor/MacTextBackgroundColor/etc and sets background to "dark" by default). I probably should have mentioned that in the release notes.

The macvim colorscheme does seem to have a bug in that it assumes the system colorscheme to be in light mode which I need to fix.

For a temporary solution you can manually invoke this or put it in your vimrc (do it after loading the colorscheme if you are doing that):

hi Normal       gui=NONE guifg=Black guibg=White
hi Visual       guibg=#72F7FF

It actually seems like there's some issue with the default macvim colorscheme when you have using normal Mojave mode but setting background to "dark" too (the text selection colors are off). Probably need to fix that as well.

ychin avatar Feb 19 '19 15:02 ychin

Yeah, I'm using the default macvim colorscheme

That temporary solution works by manually invoking it. Doesn't seem to be working from my .vimrc, but that's probably unrelated.

That screenshot is of my entire .vimrc file.

kieve avatar Feb 19 '19 16:02 kieve

Sorry, I actually meant the gvimrc, not the vimrc. If you don't have one, you can make one at ~/.gvimrc and put those lines in.

ychin avatar Feb 19 '19 16:02 ychin

Yup, that works! Thanks for the help.

kieve avatar Feb 19 '19 16:02 kieve

This should be fixed in snapshot-156 without the hack.

ychin avatar Feb 19 '19 19:02 ychin

any plans to put this into a released version?

pjmeisch-cc avatar May 21 '19 13:05 pjmeisch-cc

Sorry for the delay. I have been a little held up and currently trying to finish snapshot 156 which only has bug fixes and I do plan on including this. I don't have a firm ETA yet.

ychin avatar May 22 '19 11:05 ychin

How did you get the dark mode to work? I've tried everything I can think of and macvim always looks like this...

image

9mm avatar Jan 05 '20 02:01 9mm

@kieve

9mm avatar Jan 05 '20 02:01 9mm

@9mm I don't recall. I think I just had my OS set to dark theme, and it just worked.

kieve avatar Jan 18 '20 15:01 kieve