macvim icon indicating copy to clipboard operation
macvim copied to clipboard

Highlight feature "gui=strikethrough" does not display strikethrough text.

Open jtvoorhies opened this issue 5 years ago • 1 comments

Highlight feature "gui=strikethrough" does not display strikethrough text.

To Reproduce

  1. Run mvim --clean
  2. Create or edit an html file
  3. Type <strike>some text</strike> or :highlight htmlStrike
  4. Observe "gui=strikethrough" yet the strike mark is not on the text.

Expected behavior The highlight feature "gui=strikethrough" should show a strikethrough

Screenshots Screenshot attached.

Environment (please complete the following information):

  • Vim version: VIM - Vi IMproved 8.2 (2019 Dec 12, compiled Mar 3 2020 12:05:00) macOS version Included patches: 1-319 Compiled by [email protected] Huge version with MacVim GUI.
  • OS: macOS 10.15.4
  • Terminal: MacVim GUI mvim --clean no strikethrough

jtvoorhies avatar Apr 04 '20 02:04 jtvoorhies

Yeah we should add this. Maybe next release where we look at getting the renderer fix in.

ychin avatar Apr 07 '20 06:04 ychin

Hi, is there any update on this? Thanks.

qiqiboy avatar Sep 14 '22 12:09 qiqiboy

I forgot about this, that's all. I'm preparing a release right now, but let me see if it's easy to squeeze this in before the release.

Also, interestingly, Apple's terminal still doesn't support strikethrough it seems. iTerm does though, of course.

ychin avatar Sep 14 '22 19:09 ychin

Actually, sorry, but I think I'll push this till r175 (the one after the coming release) since I kind of want to push it out soon, and I want to make sure I get the rendering to look correct, plus support the new Vim text styles in one go (double underline, dashed / dotted underlines).

ychin avatar Sep 14 '22 23:09 ychin

Nevermind what I said. I'm waiting to see if Vim will stabilize a bit before I pick a good version to release on, so we are going to squeeze it in for the coming release r174 (#1287).

ychin avatar Sep 15 '22 03:09 ychin