mousepad: Update to 0.6.2
Description
Updates Mousepad to 0.6.2, enabling GTK3 in the process.
Type(s)
- [ ] bugfix
- [x] enhancement
- [ ] security fix
Tested on
macOS 14.4.1 23E224 arm64 Xcode 15.3 15E204a
Verification
Have you
- [x] followed our Commit Message Guidelines?
- [x] squashed and minimized your commits?
- [x] checked that there aren't other open pull requests for the same change?
- [x] referenced existing tickets on Trac with full URL in commit message?
- [x] checked your Portfile with
port lint --nitpick? - [x] tried existing tests with
sudo port test? - [x] tried a full install with
sudo port -vst install? - [x] tested basic functionality of all binary files?
- [x] checked that the Portfile's most important variants haven't been broken?
The build error is https://trac.macports.org/ticket/68854. I'll send in a PR to update libxfce4*, which should trigger a rebuild and therefore fox the issues.
PR opened: https://github.com/macports/macports-ports/pull/23687
Once that PR is merged I'll rebase this one and it should work.
DEBUG: system: /opt/local/bin/gtk-update-icon-cache -f -t /opt/local/share/icons/hicolor
sh: /opt/local/bin/gtk-update-icon-cache: No such file or directory
Command failed: /opt/local/bin/gtk-update-icon-cache -f -t /opt/local/share/icons/hicolor
Exit code: 127
Error: Failed to activate mousepad: command execution failed
Hmm, it works fine on my system, perhaps there's a missing dep/builddep?
OK, now it's failing locally as well. What's weird is that this build worked before the rebase on #23687...
Ah, it's because gtk2 is no longer installed, and gtk3's gtk-update-icon-cache is called gtk-update-icon-cache-3.0. On my Ubuntu system, the main gtk-update-icon-cache is built from the GTK3 sources. Perhaps the gtk2 version should be renamed to gtk-update-icon-cache-2.0, and the gtk3 version renamed to gtk-update-icon-cache? GTK2 is long deprecated, and the list of things still using it is shrinking over time. In fact, as I get to updating more XFCE stuff, that list is going to be even smaller.
@mascguy Since you maintain the GTK packages, what are your thoughts?
Perhaps the gtk2 version should be renamed to
gtk-update-icon-cache-2.0, and the gtk3 version renamed togtk-update-icon-cache?
And then update the references them all the ports and build systems that are already familiar with their existing names? Seems like a lot of work for no benefit.
Perhaps the gtk2 version should be renamed to
gtk-update-icon-cache-2.0, and the gtk3 version renamed togtk-update-icon-cache?And then update the references them all the ports and build systems that are already familiar with their existing names? Seems like a lot of work for no benefit.
That is my concern as well.
IMO update this to use gtk-update-icon-cache-3.0 until we figure out what to do with #23731. The fewer GTK2 ports the easier any kind of transition would be.
feel free to reopen this PR once it's actually building.