macports-ports
macports-ports copied to clipboard
gajim: update to the current @1.3.3
Description
Update gajim
to the current version.
Type(s)
- [ ] bugfix
- [x] enhancement
- [ ] security fix
Tested on
macOS 10.6.8 Server Xcode 3.2.6
macOS 10.6 PPC (10A190) Xcode 3.2
@kencu @dbevans I got a question re this port actually. Readme.md
lists the following runtime deps:
- python3.7 or higher
- python3-gi
- python3-gi-cairo
- gir1.2-gtk-3.0 (>=3.22)
- python3-nbxmpp (>=2.0.4)
- python3-openssl (>=16.2)
- python3-css-parser
- python3-keyring
- python3-precis-i18n
- python3-packaging
- python3-setuptools
- gir1.2-soup-2.4
- GLib (>=2.60.0)
Now, we do not have anything looking like python3-precis-i18n
, and I am not 100% sure re python3-css-parser
.
python3-gi
is apparently py-gobject3
.
@barracuda156 you're not really making use of the "python" PG except for adding it.
You'd probably look into setting "python.default_version" early on and then not hardcoding the version number in the dependencies. Also things like ${python.bin} and variables for frameworks are defined in the PG and there is no need to do these things again manually in the Portfile. Finally, if possible switch to the default Python version (i.e., 3.10) it the package works with it.
@reneeotten Thank you, I will fix Python handling.
@reneeotten Could you help me, what the buildbot dislikes?
Run sudo find \
[10](https://github.com/macports/macports-ports/runs/6335881051?check_suite_focus=true#step:9:10)
find: /tmp/mpbb: No such file or directory
[11](https://github.com/macports/macports-ports/runs/6335881051?check_suite_focus=true#step:9:11)
Error: Process completed with exit code 1.
UPD: This is confusing since now Macports fails to parse py-gst-python
portfile for me locally, even exactly identical portfile which it has already built successfully. The following is extracted from Macports software package (I added extension and removed initial +):
PORTFILE.txt
- what error do you see?
- you should append to the configure.pre_args and configure.args, so you don't overwrite everything already there
- you don't need that destroot.cmd I believe - it's the default
- you don't need use_configure yes -- it's the default
@kencu Now I get Failed to parse file python/py-gst-python/Portfile: can't read "python.version": no such variable
when running port sync. I cannot figure out why though. I have already built these earlier:
36-111% port -v installed | grep gst-python
py38-gst-python @1.20.2_0 (active) requested_variants='' platform='darwin 10' archs='ppc' date='2022-05-08T01:29:38+0800'
py39-gst-python @1.20.2_0 (active) requested_variants='' platform='darwin 10' archs='ppc' date='2022-05-08T01:28:03+0800'
@barracuda156 I updated to the latest upstream version, cleaned-up the Portfiles, added the new dependency. The program starts, but I other than that I have no idea what to do with it ;)
Please give it a try and, if possible, verify that the variants are still relevant/needed. If needed, can you please provide a description for each of them as to silence the lint
warnings?
[edit: well.... this now to need a newer version of gstreamer1-gst-plugins-base
for the audiovideo
variant - that's more work than I am willing to put in. The "default" version of gajim
does install and run though...]
A few comments, in no particular order...
For py-gst-python
:
- The port needs a lib dependency on
gstreamer1
, based on a quick test with trace mode enabled. (You can drop the lib dep for the plugins base port.) - The version you're trying to publish - 1.20.2 - requires a newer version of
gstreamer1
. (Per the log:Dependency gstreamer-1.0 found: NO found 1.16.2 but need: '>= 1.20.0'
.) But that stack is very complicated to update, which is why it hasn't been done. In short, downgrade this port to 1.16.2, and test to be sure it works with our currentgstreamer1
port.
For py-css-parser
- This port is outdated; latest is 1.0.9. Once you downgrade
py-gst-python
, be sure that the latter works with the latest version ofpy-css-parser
. if not, you'll need to downgrade this one too.
For
py-gst-python
:* The port needs a lib dependency on `gstreamer1`, based on a quick test with trace mode enabled. (You can drop the lib dep for the plugins base port.)
It turns out that you do indeed need a lib dep for both gstreamer1
and gstreamer1-gst-plugins-base
. So don't drop the latter after all.
A few comments, in no particular order...
For
py-gst-python
:
- The port needs a lib dependency on
gstreamer1
, based on a quick test with trace mode enabled. (You can drop the lib dep for the plugins base port.)- The version you're trying to publish - 1.20.2 - requires a newer version of
gstreamer1
. (Per the log:Dependency gstreamer-1.0 found: NO found 1.16.2 but need: '>= 1.20.0'
.) But that stack is very complicated to update, which is why it hasn't been done. In short, downgrade this port to 1.16.2, and test to be sure it works with our currentgstreamer1
port.
@mascguy I actually have it updated locally (moved to mesonbuild
etc.). May not be the latest versions already, I did updates a while ago, but way ahead of Macports. That is why, apparently, gajim
update was just fine locally with all used versions of dependencies.
I can try making a PR for those, we will need to see if Clang builds are fine. I used GCC to build everything, as always.
Closing since: https://github.com/macports/macports-ports/commit/b8ad888e64a7aac5d6e0de1dd126e21ea4a60fab