macports-ports icon indicating copy to clipboard operation
macports-ports copied to clipboard

jasper: update to 3.0.6

Open jmroot opened this issue 3 years ago • 11 comments

JasPer version 3 comes with an ABI break and also a handful of API changes (mostly minor, but changes nonetheless): https://jasper-software.github.io/jasper-manual/releases/version-3.0.2/html/index.html#overview__news

Hopefully CI will show what needs to be fixed.

jmroot avatar Feb 14 '22 12:02 jmroot

Notifying maintainers: @MarcusCalhoun-Lopez for port qt5, qt511, qt513, qt53, qt55, qt56, qt57, qt58, qt59. @Veence for port saga. @mascguy for port gdk-pixbuf2, gegl-0.3, gegl-devel, gegl, ufraw. @jswhit for port py-pygrib. @tenomoto for port magicspp, metview, wgrib2. @ryandesign for port ResIL, libdevil, GraphicsMagick, dcraw, exact-image, netpbm. @dardo82 for port libicns. @cgilles for port digikam. @NicosPavlov for port kdelibs4, kopete. @petrrr for port py-nio.

macportsbot avatar Feb 14 '22 12:02 macportsbot

Given the number of dependents being rev-bumped, I'll be shocked if the CI jobs are able to finish without timing out. Particularly given that a number of QT ports are involved.

So, I'm wondering if it might make sense to create a Devel port for Jasper? (Along with updating dependents to use a path-style dep.)

Then we can test our various ports against jasper-devel, and report back with the results.

Josh, your thoughts?

mascguy avatar Feb 14 '22 17:02 mascguy

digiKam use Jasper toolkit to deal with JPEG2000. I'm in contact with Jasper lead developer about the new 3.x release. Warning : API has changed and needs fixes from client code to run. It can compile but not run properly as well, depending of the features used from the library. For digiKam a test plan is planed in the near future, when time permit. I recommend to prepare the update of libjasper port and wait a little bit to see if all is fine from client code. Just my 10 cts. Gilles Caulier

cgilles avatar Feb 14 '22 17:02 cgilles

I recommend to prepare the update of libjasper port and wait a little bit to see if all is fine from client code.

Certainly; that's the purpose of this PR.

jmroot avatar Feb 14 '22 17:02 jmroot

These ports need build fixes due to jasper changes: exact-image, libdevil, wgrib2, xv

These ports were already failing before this change: ResIL, gstreamer010-gst-plugins-bad, digikam, kdelibs4 (maybe?), kopete, metview

qt*-qtimageformats need to be tested manually because CI wants to build all the unchanged subports as well.

jmroot avatar Feb 15 '22 10:02 jmroot

Josh, pushed one additional commit, with two minor changes. (Purposely didn't squash the change, so that you can see what was updated.)

mascguy avatar Feb 19 '22 15:02 mascguy

Josh, I fixed the merge conflicts with gdk-pixbuf2 and gegl-devel (both recently updated), along with bumping Jasper to 3.0.2.

mascguy avatar Mar 05 '22 17:03 mascguy

Josh, I fixed the merge conflicts with gdk-pixbuf2 and gegl-devel (both recently updated), along with bumping Jasper to 3.0.2.

But no worries if you'd prefer to stick with 3.0.1, and/or not include the other portfile changes. (The latter to be consistent with jasper-devel.)

mascguy avatar Mar 05 '22 17:03 mascguy

It looks like we'll need to make an additional change, to fix builds for 10.7 through 10.9.

Blacklisting older Clang versions would likely take care of it. But alternatively, we might need to bump the cxx standard.

https://build.macports.org/builders/ports-10.9_x86_64-builder/builds/181045/steps/install-port/logs/stdio

mascguy avatar Mar 05 '22 18:03 mascguy

Rebased against master, and fixed merge conflicts.

mascguy avatar May 21 '22 15:05 mascguy

Rebased against master, and updated to 3.0.6.

mascguy avatar Jul 16 '22 16:07 mascguy

Rebased against master, to fix merge conflict.

mascguy avatar Sep 09 '22 14:09 mascguy

Port updated via commit:

https://github.com/macports/macports-ports/commit/5341ba92b2f5af75558379b8af93a65d4ce33f3a

mascguy avatar Sep 10 '22 16:09 mascguy