macports-base icon indicating copy to clipboard operation
macports-base copied to clipboard

Abort 'port test' early if test.run is set to no

Open kurthindenburg opened this issue 4 years ago • 6 comments

This will avoid installing dependencies if tests is not enabled.

Closes: https://trac.macports.org/ticket/45010

kurthindenburg avatar Jun 11 '20 02:06 kurthindenburg

Hm, it seems that this actually breaks a couple of tests. Please take a look.

neverpanic avatar Jun 13 '20 14:06 neverpanic

Yea I missed that.... strange a lot of tests under tests/test fail even though they don't set test.run.

kurthindenburg avatar Jun 13 '20 14:06 kurthindenburg

When running those tests, the target is "test" and they don't have test.run in the Portfiles so it fails. I wonder since the tests Portfiles all have 'test {}' in them, that this is why these fail.

kurthindenburg avatar Jun 13 '20 14:06 kurthindenburg

I'm not sure this is the best or even correct way to fix this.

kurthindenburg avatar Jun 13 '20 20:06 kurthindenburg

Before I work on this again, does anyone object or have suggesting for a better way to handle the test portion? It does work as-is, just seems hackish.

kurthindenburg avatar Jul 27 '20 16:07 kurthindenburg

Just getting around to reviewing these PRs, so my apologies for not responding sooner.

I'll try to circle back on this over the coming weeks, when I can take a breather.

Regardless, I like the idea!

mascguy avatar Oct 28 '21 00:10 mascguy

Shouldn't be needed any more after ddc2655.

jmroot avatar Nov 08 '23 06:11 jmroot