macos_ui icon indicating copy to clipboard operation
macos_ui copied to clipboard

ProgressCircle color does not follow MacosTheme

Open adiletcool opened this issue 10 months ago • 3 comments

Description

ProgressCircle is not visible when using light theme

Steps To Reproduce

  1. Specify MacosApp(themeMode: ThemeMode.light)
  2. Create simple ProgressCircle() without value.

Expected behavior

class ProgressCircle extends StatelessWidget {
    ...

  @override
  Widget build(BuildContext context) {
    if (isDeterminate) {
        ...
    } else {
      return Semantics(
        label: semanticLabel,
        child: c.CupertinoActivityIndicator(
          radius: radius,
          color: MacosTheme.of(context).primaryColor, // should use primary color or color specified in parameters
        ),
      );
    }
}

adiletcool avatar Feb 21 '25 20:02 adiletcool

Not sure about primaryColor, maybe it should be same as other icons color.

adiletcool avatar Feb 21 '25 20:02 adiletcool

This might be related (assuming the issue only persists when the light theme is set explicitly): https://github.com/macosui/macos_ui/issues/552

Adrian-Samoticha avatar Feb 24 '25 14:02 Adrian-Samoticha

I am observing the same. Even though PR #552 is already closed, this behaviour is still observable. E.g.:

Image Image

petrockblog avatar Apr 19 '25 10:04 petrockblog