macos_ui icon indicating copy to clipboard operation
macos_ui copied to clipboard

Refactor `PushButton` API surface for variant clarity

Open GroovinChip opened this issue 2 years ago • 0 comments

According to the Sonoma Figma Kit, there are three variants of push buttons:

  • primary
  • secondary
  • destructive

Push Buttons

Styling Requirements:

  • The background color of primary buttons should always be the system accent color or the color set in PushButtonThemeData.
  • The background color of secondary buttons should always be the default white/dark grey color unless overridden by PushButtonThemeData.
  • The background color of destructive buttons should always be the default white/dark grey, and the button's text should always be styled to the shade of red appropriate for current theme. Destructive buttons should not respect the background color set by PushButtonThemeData.

Implementation Steps

### Tasks
- [ ] Introduce `PushButtonVariant` enum
- [ ] Remove `color` property
- [ ] Remove `isSecondary` property
- [ ] Apply styling requirements

GroovinChip avatar Jul 05 '23 15:07 GroovinChip