Mark Cohen
Mark Cohen
@anirudha any thoughts on this proposal?
@evankielley are you working on this? I want to assign to you (I see the PR), but I can't until you have participated in the issue itself. thanks.
So, to confirm, when you say one-by-one, it's this approach: 1. add a lint 2. run pylint 3. fix ALL the failures 4. go to 1 until out of lints...
Doing this incrementally, what do you think of breaking this down into an issue per lint? It becomes a much less daunting single task and can be picked up in...
Running utils/build_dists.py results in an error: Installing collected packages: urllib3, six, idna, charset-normalizer, certifi, requests, python-dateutil, opensearch-py2 Successfully installed certifi-2023.11.17 charset-normalizer-3.3.2 idna-3.6 opensearch-py2-2.4.3 python-dateutil-2.8.2 requests-2.31.0 six-1.16.0 urllib3-1.26.18 $ /var/folders/33/jx0mw87156q2hmtrr_r82s7r0000gs/T/tmpko79lorv/venv/bin/python -c...
got that one. it is only called from GitHub Actions. Also, I've been adding a lot of "# pylint: disable=missing-function-docstring" instructions to any function starting with def test_ or async...
Should the opensearchpy directory be ignored for pylint? That code is generated (I think) so maybe the generator needs to include the docstrings and other items.
Tracking them here as I add: - [x] missing-function-docstring - [ ] missing-class-docstring - [ ] protected-access - tried this one locally; need more in-depth understanding of the code. -...
@saimedhi is there a priority on the lints you'd like to see above? I've been tackling them based on what looks interesting to report on and not too much of...
I started this gist for collaboration: https://gist.github.com/macohen/e7c1b6ae76e3045572a836f767a3ee3d