get OPTIONS working

[mvayngrib]

trafficstars

uses the trick learned here: https://github.com/awslabs/aws-serverless-express/issues/58 https://github.com/awslabs/aws-serverless-express/issues/58#issuecomment-303193847 https://github.com/awslabs/aws-serverless-express/issues/58#issuecomment-322263402

to solve the problem discussed here; https://github.com/serverless/serverless/issues/2797#issuecomment-331698109

i also refactored the stage/apiId variables to be instance variables, they were a pain to pass around

i understand if you don't want to merge this for lack of tests, so either I'll get to it when I have time, or someone else will :)

[maciejtreder]

@mvayngrib Thanks for this PR!

Yup, you're right. We definetely need tests here. I will try to add some, but I am afraid that it won't happen quickly (my backlog is really full for next 2 months).

So if you will have any free time, please add those.

Thanks i advance!

[mvayngrib]

todo: load the cors config from the function's cors config

[stormit-vn]

We really need this feature in place, so anyone can help to get this PR merged?

Thank in advance!

[maciejtreder]

@mvayngrib Could you resolve conflicts with the master branch, so we could go forward with merge?

[mvayngrib]

@maciejtreder I updated the PR.

Keep in mind that this is still missing copying over of the cors config, so if people have custom headers they want allowed, they will be sad :)

[maciejtreder]

@mvayngrib Ouch... You're right..

Will you find time to implement CORS configuration rewrite/copy?

[mvayngrib]

@maciejtreder i was trying to see the other day how serverless parses it out, and it's somewhere in the bowels of the code: https://github.com/serverless/serverless/blob/master/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.js#L298

do you know how we might access that method?

[rcstr]

any update on this? what's missing? anything I can help with?

[mvayngrib]

@rcstr yep! Read above about CORS

[Ponjimon]

Hello,

is there any status update here?