ng-toolkit icon indicating copy to clipboard operation
ng-toolkit copied to clipboard

@ng-toolkit/universal failed with Angular 9

Open basevers opened this issue 4 years ago • 8 comments

I'm submitting a...


[ X ] Bug report  
[ ] Feature request
[ ] Documentation issue or request

In package


[ ] @ng-toolkit/init
[ ] @ng-toolkit/serverless
[ X ] @ng-toolkit/universal
[ ] @ng-toolkit/pwa
[ ] @ng-toolkit/firebug

Current behavior

When following step by step instructions listed here: https://medium.com/@maciejtreder/angular-server-side-rendering-with-ng-toolkit-universal-c08479ca688

An error occurs when adding ng-toolkit/universal and the npm run build:prod script is missing

Expected behavior

Minimal reproduction of the problem with instructions

$ ng version Angular CLI: 9.0.0 Node: 12.16.1 OS: linux x64

Angular: ... Ivy Workspace:

Package Version

@angular-devkit/architect 0.900.0 @angular-devkit/core 9.0.0 @angular-devkit/schematics 9.0.0 @schematics/angular 9.0.0 @schematics/update 0.900.0 rxjs 6.5.3

$ ng new test ......

$ cd test $ng add @ng-toolkit/universal Installing packages for tooling via npm. Installed packages for tooling via npm. ERROR: newTree.optimize is not a function ERROR: If you think that this error shouldn't occur, please fill up bug report here: https://github.com/maciejtreder/ng-toolkit/issues/new INFO: stacktrace has been sent to tracking system. Nothing to be done.

$ npm run build:prod npm ERR! missing script: build:prod npm ERR! npm ERR! Did you mean this? npm ERR! build

Example repository

What is the motivation / use case for changing the behavior?

Environment


Angular CLI: 9.0.0
Node: 12.16.1
OS: linux x64

Others:

basevers avatar Feb 24 '20 06:02 basevers

The package isn't compatible with the new Angular v9 version. I haven't found enough free time to fix issues with the Angular v8 and therefore, support for v9 would take a while.

KingDarBoja avatar Feb 24 '20 15:02 KingDarBoja

When we can except version for v9 ?

todorpavlovic avatar Apr 22 '20 19:04 todorpavlovic

Any update on this yet?

jpekeene avatar Jun 14 '20 12:06 jpekeene

Is it compatible with Angular v 10 ?

kik-doctor avatar Jul 06 '20 08:07 kik-doctor

@KingDarBoja do you know how to host or deploy angular app with ssr? I have website but it doesn't have SEO so I used @ng-toolkit/universal then I want it to deploy

Mottihh avatar Jul 19 '20 05:07 Mottihh

Any update please?

geetika-kathuria avatar Aug 20 '20 04:08 geetika-kathuria

@KingDarBoja do you have any plan to add support for Angular 9 or 10 to toolkit/universal?

adimango avatar Aug 31 '20 19:08 adimango

Yes, working on it, please take a look at #826

KingDarBoja avatar Aug 31 '20 19:08 KingDarBoja