spotlight icon indicating copy to clipboard operation
spotlight copied to clipboard

ENH: using sklearn.utils for creating RNGs and generating minibatches

Open dohmatob opened this issue 6 years ago • 5 comments

Spotlight already depends on scikit learn (sklearn), so we could delegate even more stuff to the later.

dohmatob avatar Mar 13 '18 06:03 dohmatob

Looks good, thanks for the contribution!

Could you fix the flake8 issue please?

maciejkula avatar Mar 13 '18 11:03 maciejkula

Fixed the flake issue. Now there is a mystical failure which seems to be affecting other open PRs too.

UnsatisfiableError: The following specifications were found to be in conflict:
  - chardet -> python[version='>=3.6,<3.7.0a0']
  - python=2.7
Use "conda info <package>" to see the dependencies for each package.

dohmatob avatar Mar 13 '18 19:03 dohmatob

Yes, the dependencies seem to have moved in an annoying way. I'll do my best to resolve this.

maciejkula avatar Mar 13 '18 19:03 maciejkula

Could you please rebase on top of newest master?

maciejkula avatar Mar 15 '18 17:03 maciejkula

Can you rebase please? Otherwise I'll close this and re-open the PR with rebased code.

maciejkula avatar Apr 03 '18 13:04 maciejkula