json-rust icon indicating copy to clipboard operation
json-rust copied to clipboard

Should json-highlight-writer be added to json-rust?

Open gmmorris opened this issue 6 years ago • 1 comments

Hi, Thanks for all your great work on json-rust!

I recently needed a way of writing a json object with highlights on certain slices for my work on gmmorris/jg.

To achieve this I wrote an external writer which takes your json-rust implementation which I have published as json-highlight-writer. This required duplicating some code from json-rust (license kept in tact, as you can see) as it wasn't exposed in a consumable manner.

My original intent was to keep the highlight-writer as an external writer and use it in the manner you can see in the jg library, but it occurred to me that it might be worth offering to add it as a build in writer in json-rust.

Before I go to the effort of putting together a pull request I wanted to make sure there's an interest. If not, I'm happy to keep it external. :)

Cheers

gmmorris avatar May 11 '19 12:05 gmmorris

Hey, Sorry to bug, I know as well as anyone how much strain maintaining OSS can be, I'm just trying to avoid an throwing an unwanted PR at you out of nowhere. :)

I was just hoping to hear some thoughts on whether you also think it would be valuable integrating a writer that can add colourful highlights to the json output into json-rust or whether this is better left as external (sadly that requires some duplicated code between the projects)?

I'm fine with a negative answer (in which case, we can close this issue), I was just hoping for some feedback. :)

Cheers

gmmorris avatar Aug 05 '19 09:08 gmmorris