Maciej Hirsz

By default, and per spec, any extra characters at the end are to be considered errors, however I think I can add that as an option with a generic on...

The `object!` macro always produces a `JsonValue::Object` variant. You can unwrap it with `if let JsonValue::Object(object) = value { ... }`. I haven't been doing much here for a while,...

If you are pushing onto `array![]`, you can do either: ```rust if let json::JsonValue::Object(object) = value { data.push(object); // not `value`, otherwise you can't take ownership of `value` line above....

What line is that error on? It seems you are borrowing the values here: ``` "ex_order_id" => &item["child_order_id"], "ex_execution_id" => &item["child_order_acceptance_id"], ... ``` You can try getting an owned iterator...

@abbychau you can find me on [Ratel Gitter](https://gitter.im/ratel-rust/Lobby). It seems to me the issue is what I described above.

> This is also important for sending stuff to Elasticsearch, which doesn't accept floating point values without a decimal point. You mean it doesn't accept `10` as `10.0`? How do...

That's a rather strange design decision, JSON has no concept of floats or integers (in fact the actual number format is so loosely defined it could mean anything). I'm asking...

`count()` could be better?

Thanks! I also let that domain drop, I'll need to move it elsewhere.

There is nothing OS specific in the code, I'm on linux now but the crate was originally built on OSX. Do you have an example on GitHub that I could...