ec2-github-runner icon indicating copy to clipboard operation
ec2-github-runner copied to clipboard

Allow providing ec2-instance-count to start multiple runners

Open dexbleeker opened this issue 2 years ago • 5 comments

Fixes #8

This PR is based on the fork of @messense, specifically this commit.

It allows for providing ec2-instance-count as input variable and will start multiple runners if desired. By default 1 runner is started.

Note that this might not be the cleanest code or best implementation. I don't write JS generally and have not touched a GH action before. Especially Array.from(JSON.parse(ec2InstanceIds)) feels wrong.

All feedback is welcome however.

dexbleeker avatar Aug 18 '23 11:08 dexbleeker

Works like a charm

@machulav 👀

mickmorse avatar Aug 18 '23 19:08 mickmorse

Only comments are to update the readme surrounding the outputs and examples (with it now being ec2-instance-ids)

mickmorse avatar Aug 18 '23 19:08 mickmorse

Any plans to merge this?

wu-json avatar Oct 13 '23 20:10 wu-json

MinCount/MaxCount are not used anywhere, shouldn't it be a specific count, why there's a min/max, kind of "if at least N will successfully be created" ? a useful feature for me too, i wonder why won't be merged :(

Dmitry1987 avatar Dec 11 '23 14:12 Dmitry1987

+1 Very useful feature for us too.

thimios avatar Mar 28 '24 18:03 thimios