ec2-github-runner icon indicating copy to clipboard operation
ec2-github-runner copied to clipboard

chore(logic): Runner should be removed before termination

Open dev-slatto opened this issue 1 year ago • 2 comments

The EC2 instance should be marked as unschedulable by Github Actions before termination to make sure that Github Actions dosen't schedule any jobs to it while it's being terminated.

dev-slatto avatar Aug 09 '23 09:08 dev-slatto

definitely the correct way to do it, why it wasn't merged 😢

Dmitry1987 avatar Dec 11 '23 15:12 Dmitry1987

oh i see the comments, gh.remove() will mark it unschedulable, aha. PRs remain open, should be just closed if the fix is not relevant anymore 🙃

Dmitry1987 avatar Dec 11 '23 15:12 Dmitry1987