emblem.js icon indicating copy to clipboard operation
emblem.js copied to clipboard

Yielded Components render as Class instead of property

Open ilovethebends opened this issue 5 years ago • 5 comments

It seems that for glimmer emblem treats nested properties as classes.

% MyForm::MyFormGroup as |formGroup|
	%formGroup.label @name="Ed"

label gets compiled into a class instead of a property on formGroup

<MyForm::MyFormGroup as |formGroup|>
  <formGroup @name="Ed" class="label"></formGroup>
</MyForm::MyFormGroup>

The other issue I'm finding is that %formGroup.label @name="Ed" gets translated into a block component instead inline.

Thanks in advance!

ilovethebends avatar Dec 18 '19 19:12 ilovethebends

Is this dead? It is a real shame because I like emblem, but not supporting glimmer components will make it kind of unusable.

wmlele avatar Apr 28 '20 13:04 wmlele

Added a PR #341

wmlele avatar Apr 28 '20 16:04 wmlele

I'd be glad to see this issue resolved too. For now, we need to jungle between .emblem and .hbs depending on the use of yielded components or not in the template. And I really miss Emblem's elegance when writing those Handlebars files…

Thanks @wmlele, this PR of yours looks pretty good!

dfriquet avatar Jun 24 '20 07:06 dfriquet

@thec0keman @machty any chance of getting this merged in?

kjhangiani avatar Jun 26 '20 00:06 kjhangiani

@thec0keman @machty Any chance you take a look at this issue in a near future?

@wmlele @kjhangiani Are you using some other fork of EmblemJS in production or have you thrown EmblemJS away altogether?

dfriquet avatar Dec 04 '20 16:12 dfriquet