ember-concurrency icon indicating copy to clipboard operation
ember-concurrency copied to clipboard

Cancelling task does not update group's isRunning property

Open GendelfLugansk opened this issue 7 years ago • 1 comments

Version: 0.8.7 Ember version: 1.13.11 Steps to reproduce:

  • Create a long-running task and assign it to group
  • Perform task
  • Cancel task using task's cancelAll method or cancel-all helper

Expected result: Group's isRunning property is false after cancellation Actual result: Group's isRunning property is true

GendelfLugansk avatar Aug 10 '17 00:08 GendelfLugansk

I tried to debug a little and found out that if I replace line 30 of -scheduler.js with Ember.run.next(null, flushTaskCounts, seen);, cancellation works as intended. However, I'm not sure if this fix is correct and wouldn't break something else.

GendelfLugansk avatar Aug 10 '17 08:08 GendelfLugansk